[ENH] UserInteraction can be extended by shift.#336
Merged
ales-erjavec merged 1 commit intobiolab:masterfrom Sep 26, 2025
Merged
Conversation
Introduced flag for keep state if shift was pressed on interaction ends. Use this for arrow adnotation operation.
krystofair
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #336 +/- ##
==========================================
- Coverage 76.54% 76.07% -0.48%
==========================================
Files 102 102
Lines 21316 21326 +10
==========================================
- Hits 16317 16224 -93
- Misses 4999 5102 +103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Like in description: Added flag for keep state across whole user interactions (in UserInteraction class) and implement it for ArrowAnnotation.
I Pull Request this feature, because I think this is some kind of intuitive and decrease mouse move when we repeat the same operation.
Of course
shiftis my personal choice, so ifctrlbe better, the change is straightforward.